Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Table First draft #435

Merged
merged 45 commits into from
Feb 22, 2024
Merged

Generic Table First draft #435

merged 45 commits into from
Feb 22, 2024

Conversation

saynb
Copy link
Contributor

@saynb saynb commented Jun 16, 2023 •
edited
Loading

  • Phase 1:
    Objective : Phase 1 aims to provide support for a set of simple target-specific externs through GenericTables. Current APIs should work on the tables as intended. Read-write symmetry should be maintained wherever possible. Have a structure in place in p4info with which new type system and properties at different granularities can be specified and maintained.

    • Not extend any of the current RPC updates. Use INSERT, MODIFY, DELETE and Read RPC as is
    • Define Table categories/ properties
    • Define Entry and Field properties
    • Define Type system
    • Achieve Write/Read for simple PNA specific externs like ExactValueMatchLookupTable
    • Work on generic-table-dev

  • Phase 2
    Extend API list and other features.

    • Entry Handles
    • Table attributes (symmetric vs asymmetric)
    • New APIs
      • reset
      • add_or_mod
      • sync
      • usage_get
      • mod_inc
    • Table custom operations extensions. A way to define new operations via json modeling. For example, sync

  • Phase 3

    • String representation of fields. Like IPv4 IPv6
    • Table notifications. Model notifications in a generic way

saynb added 13 commits April 12, 2023 18:17
@saynb
Initial changes for generic tables
e553d88
@saynb
second changes
1d8eff5
@saynb
3rd changes
4690968
@saynb
4th changes
55bf9be
@saynb
5th changes
f775ddc
@saynb
Adding p4types and p4info changes for GenericData (#4)
07b2da6 
Adding another enum alongside P4IDs for generic tables as well
@saynb
Adding varbits and a readme writeup (#5)
e4a5309 
* Adding varbit and a writeup
@saynb
Adding proto changes
fd132e7
@saynb
Adding genericTable for direct resources. Adding P4datatypespec to ge…
2a5eae6 
…nericdatatype in p4types
@saynb
* Adding more container types
35dc65a 
** list
** bag
** set
** ordered_set

* Moving GenericTable spec update to one big section to keep it
organized
@saynb
* Add Table categories introduction
6e7c5f1
@saynb
* Adding 3-level property details (Table, Entry, field)
d6e042b 
* Adding more text on the data types in the spec
* Adding Details on Operations in the Table categories
@saynb
* Adding Read RPC details in table categories
53b105f 
* Adding a table to show valid combinations of table properties
* Adding default entry rules
@chrispsommers chrispsommers mentioned this pull request Jun 16, 2023
Closed
chrispsommers
chrispsommers reviewed Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miscellaneous comments and small fixes.

@saynb
Review comments
9ff6e4e 
Signed-off-by: Sayan Bandyopadhyay <[email protected]>
saynb
saynb commented Nov 8, 2023
View reviewed changes
docs/v1/P4Runtime-Spec.mdk Outdated Show resolved Hide resolved
@saynb
Correcting whitespace errors
0fcf0c4 
Signed-off-by: Sayan Bandyopadhyay <[email protected]>
jamescchoi
jamescchoi approved these changes Dec 7, 2023
View reviewed changes
Copy link

@jamescchoi jamescchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed.

@chrispsommers
Copy link
Collaborator

@jafingerhut @smolkaj @jonathan-dilorenzo Last call for comments/approval. it;d be nice to merge this into the dev-branch which in any case is DRAFT.

@saynb Is this synced with main?

@saynb
Copy link
Contributor Author

saynb commented Dec 7, 2023

@jafingerhut @smolkaj @jonathan-dilorenzo Last call for comments/approval. it;d be nice to merge this into the dev-branch which in any case is DRAFT.

@saynb Is this synced with main?

The generic-table-dev branch needs to be synced with main. I can then git merge it in this private branch. Can you please help with that?

@chrispsommers
Copy link
Collaborator

@saynb Sure, just make the PR and tag me, thanks.

jafingerhut
jafingerhut approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saynb
Resolving conflicts in spec and proto only
71eef58 
Merge remote-tracking branch 'p4lang/generic-table-dev' into generic_table_2

Signed-off-by: Bandyopadhyay, Sayan <[email protected]>
@saynb
Updating generated code
8bbd503 
Signed-off-by: Sayan Bandyopadhyay <[email protected]>
@chrispsommers chrispsommers merged commit cc1e04e into p4lang:generic-table-dev Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescchoi jamescchoi jamescchoi approved these changes

@chrispsommers chrispsommers chrispsommers approved these changes

@jafingerhut jafingerhut jafingerhut approved these changes

@smolkaj smolkaj Awaiting requested review from smolkaj

@jonathan-dilorenzo jonathan-dilorenzo Awaiting requested review from jonathan-dilorenzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saynb @chrispsommers @jafingerhut @jonathan-dilorenzo @jamescchoi @antoninbas